Fixes #9744: No server inventory in web interface if /etc/hosts is not correctly configured #1144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Dec 2, 2016
| @@ -183,6 +183,8 @@ function generate_promises_at_temporary_location() { | |||
|
|
|||
| cp -r /opt/rudder/share/initial-promises/ ${TMP_DIR}/community | |||
|
|
|||
| [ -n "${COMPUTED_ALLOWED_NETWORKS}" ] COMPUTED_ALLOWED_NETWORKS="${COMPUTED_ALLOWED_NETWORKS}," | |||
There was a problem hiding this comment.
Looks like there is a missing "&&"
|
Commit modified |
peckpeck
force-pushed
the
bug_9744/no_server_inventory_in_web_interface_if_etc_hosts_is_not_correctly_configured
branch
from
bad89fa
to
9b8d61a
Compare
|
Why targeting 3.2 and not 3.1? |
…t correctly configured
peckpeck
force-pushed
the
bug_9744/no_server_inventory_in_web_interface_if_etc_hosts_is_not_correctly_configured
branch
from
9b8d61a
to
b749d45
Compare
|
PR replaced by #1149 |
peckpeck
deleted the
bug_9744/no_server_inventory_in_web_interface_if_etc_hosts_is_not_correctly_configured
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9744