Fixes #3925 - Prevent UUID to be removed #119
Conversation
…, and set 'root' to UUID only during rudder-server-root install but use the script during upgrade
|
PR Updated. I've added a new script to install for rudder-agent packages and will be used by cron. This script will check CFEngine and UUID for the moment. |
| # If the UUID is not valid, regenerate it | ||
| if [ ${CHECK_UUID} -ne 1 ]; then | ||
| echo -n "INFO: Creating a new UUID for Rudder as the existing one is invalid..." | ||
| uuidgen > ${UUID_FILE} |
There was a problem hiding this comment.
I think we should make a backup copy of the old UUID before savagely overwriting it.
|
Pull Request Updated. |
…ckage, Add temporary cron set into rudder-agent postinst and comments for check-rudder-agent
| # in order to remove it later without complains of the package manager. | ||
| CHECK_RUDDER_AGENT_CRON=`grep "check-rudder-agent" techniques/system/common/1.0/rudder_agent_community_cron.st | wc -l` | ||
| # Add it only if the default cron file does not call check-rudder-agent script | ||
| if [ ${CHECK_RUDDER_AGENT_CRON} -ne 1 ]; then |
There was a problem hiding this comment.
This seems like rather sloppy logic in the test. What we want to test is whether the cron file contains a call to "/opt/rudder/bin/check-rudder-agent". Why not use that in your grep rather than a substring? Also, why check" ==1" rather than "!=0", which is what we care about?
Code should reflect intent, otherwise it is hard to link the implementation to the logic that brought the author to it.
There was a problem hiding this comment.
Also, this check is not sufficient - one should only run the echo and chmod commands if the temporary file does not exist.
|
Pull Request updated ! sorry for bizarre logic and wrong files :/ |
…_no_uuid Fixes #3925 - Prevent UUID to be removed
Fixes #3925 - Prevent UUID to be removed
See http://www.rudder-project.org/redmine/issues/3925