Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3958 : Add migration script to add comment to rudder.batch.reportscleaner.frequency property #125

Conversation

VinceMacBuche
Copy link
Member

@jooooooon
Copy link
Member

Thanks for doing this Vincent, but I think it is not necessary. Adding a 4-5 line migration script to add a comment in the config file is overly zealous, and actually introduce more risk of affecting this version's stability than not doing it - it a bug is in the migration script (I'm not saying there is one, just that it could easily happen) we would future upgrades, and adding a comment is not a valid reason to do this.

I'm happy to just have this comment added to new installations of Rudder.

@jooooooon jooooooon closed this Sep 24, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants