Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10073: Redirect http to https in relay api #1259

Conversation

amousset
Copy link
Member

@peckpeck
Copy link
Member

Shouldn't you remove equivalent redirection code in webap-nossl ?

Are all our call already ssl based ?

@amousset
Copy link
Member Author

we have some exceptions:

# Rule 2 - Don't use HTTP/S for these URLs to avoid breaking the compatibility for cURL
# clients (especially in Techniques)
RewriteCond %{REQUEST_URI} !^/rudder-(not-loaded|loading).html
RewriteCond %{REQUEST_URI} !^/uuid
RewriteCond %{REQUEST_URI} !^/inventories/?
RewriteCond %{REQUEST_URI} !^/inventory-updates/?
RewriteCond %{REQUEST_URI} !^/api/?
RewriteCond %{REQUEST_URI} !^/rudder/relay-api/?

All of this could go to common as we have a cond on http/https.

@peckpeck
Copy link
Member

is the webapp calling remote run directly via ssl ?

@amousset
Copy link
Member Author

@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 9157450 into Normation:branches/rudder/4.1 Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants