Fixes #10066: Scary message about OpenSSL on SLES when running rudder agent update #1272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Mar 1, 2017
rudder-agent/SPECS/rudder-agent.spec
Outdated
| @@ -189,7 +189,7 @@ Requires: dmidecode | |||
| ### SLES 11 OSes come with OpenSSL 0.9.8h which is recent enough. | |||
| ## | |||
| # Reference for suse_version : https://en.opensuse.org/openSUSE:Build_Service_cross_distribution_howto | |||
| %if 0%{?suse_version} && 0%{?suse_version} < 1100 | |||
| %if 0%{?suse_version} && 0%{?suse_version} < 1140 | |||
There was a problem hiding this comment.
Is the openssl version higher on SP4 ? It seems to me the actual condition is < 1200
There was a problem hiding this comment.
it seems logical, it's just that we didn't do that for the other tests
|
Commit modified |
peckpeck
force-pushed
the
bug_10066/scary_message_about_openssl_on_sles_when_running_rudder_agent_update
branch
from
fb11107
to
fbcab40
Compare
amousset
reviewed
Mar 1, 2017
rudder-agent/SPECS/rudder-agent.spec
Outdated
| @@ -144,12 +144,12 @@ Requires: dmidecode | |||
|
|
|||
| ## 3 - SLES: No LMDB yet | |||
| # Reference for suse_version : https://en.opensuse.org/openSUSE:Build_Service_cross_distribution_howto | |||
| %if 0%{?suse_version} && 0%{?suse_version} < 1140 | |||
There was a problem hiding this comment.
This one is a change in OpenSuSE 11.4
peckpeck
force-pushed
the
bug_10066/scary_message_about_openssl_on_sles_when_running_rudder_agent_update
branch
from
fbcab40
to
690d090
Compare
|
Commit modified |
amousset
reviewed
Mar 1, 2017
rudder-agent/SPECS/rudder-agent.spec
Outdated
| @@ -149,7 +149,7 @@ Requires: pmtools | |||
| %define use_system_lmdb false | |||
| %endif | |||
|
|
|||
| %if 0%{?suse_version} && 0%{?suse_version} >= 1140 | |||
There was a problem hiding this comment.
This was was also OpenSuSE 11.4 specific (it is the other part of the first one)
|
Commit modified |
peckpeck
force-pushed
the
bug_10066/scary_message_about_openssl_on_sles_when_running_rudder_agent_update
branch
from
690d090
to
c181a78
Compare
|
OK, merging this PR |
|
OK, merging this PR |
peckpeck
deleted the
bug_10066/scary_message_about_openssl_on_sles_when_running_rudder_agent_update
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10066