Fixes #10425: Add migration script for hooks ignore suffixes #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR rebased |
fanf
force-pushed
the
ust_10425/add_migration_script_for_hooks_ignore_suffixes
branch
from
5747ae5
to
519a437
Compare
jooooooon
reviewed
Mar 15, 2017
rudder-webapp/SOURCES/rudder-upgrade
Outdated
| # before running a hook under /opt/rudder/etc/hooks.d. | ||
| # If an executable file has one of the following extensions, it | ||
| # will be IGNORED and the corresponding hook skipped. Non executable files are | ||
| # always ignored, with or without any of these extensions. |
There was a problem hiding this comment.
Can we please consistently use "suffixes" instead of "extensions"? Or if you think it should be "extension", then rename the property, but don't mix and match.
jooooooon
reviewed
Mar 15, 2017
rudder-webapp/SOURCES/rudder-upgrade
Outdated
| " | ||
|
|
||
|
|
||
| >>>>>>> Stashed changes |
There was a problem hiding this comment.
This looks like a git merge issue
|
PR rebased |
fanf
force-pushed
the
ust_10425/add_migration_script_for_hooks_ignore_suffixes
branch
from
519a437
to
6e81d9b
Compare
|
PR rebased |
fanf
force-pushed
the
ust_10425/add_migration_script_for_hooks_ignore_suffixes
branch
from
6e81d9b
to
5a8761d
Compare
rudder-webapp/SOURCES/rudder-upgrade
Outdated
| @@ -1,4 +1,4 @@ | |||
| #!/bin/bash | |||
| rudder.hooks.ignore-suffixes#!/bin/bash | |||
|
PR rebased |
fanf
force-pushed
the
ust_10425/add_migration_script_for_hooks_ignore_suffixes
branch
from
5a8761d
to
d314239
Compare
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/10425