Fixes #3997 - Add backup of /etc/{init.d,default}/rudder-agent in preinst and restore action in check-rudder-agent cron file #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 4, 2013 23:31
…er-agent in preinst and restore action in check-rudder-agent cron file" This reverts commit 63978b9.
…inst and restore action in check-rudder-agent cron file
|
I don't understand, why are you removing cron from this? Please explain. |
As explained in http://www.rudder-project.org/redmine/issues/3995#note-8, on branch 2.4 the cron file is not yet /etc/cron.d/rudder-agent but /etc/crontab. Then, the preinst of rudder-agent and the script check-rudder-agent will fail |
|
OK, but there is absolutely no mention of this in http://www.rudder-project.org/redmine/issues/3997, which is what this PR is linked against. How do you expect me to figure this out? Please explain yourself. This PR is OK for me then, but make sure to do a change against 2.6+ for the cron.d file. |
nperron
pushed a commit
that referenced
this pull request
Oct 5, 2013
…ng_init_and_default_of_rudder_agent
Fixes #3997 - Add backup of /etc/{init.d,default}/rudder-agent in preinst and restore action in check-rudder-agent cron file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3997 - Add backup of /etc/{init.d,default}/rudder-agent in preinst and restore action in check-rudder-agent cron file
See http://www.rudder-project.org/redmine/issues/3997