Fixes #3195 : Add migration script to add non compliant report logger to... #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -611,6 +612,12 @@ then | |||
| sed -i 's%^ *</configuration>% <logger name="historization" level="info" additivity="false">\n <appender-ref ref="OPSLOG" />\n <!-- comment the following appender if you dont want to have logs about report in both stdout and opslog -->\n <appender-ref ref="STDOUT" />\n </logger>\n </configuration>%' /opt/rudder/etc/logback.xml | |||
| fi | |||
|
|
|||
| # - 2.5.0 : Update logback.xml in order to have information about non compliant reports | |||
| if ! cat /opt/rudder/etc/logback.xml | perl -p0e 's/\n//g' | perl -p0e 's/<!--.(?:(?!-->).)*-->//g' | perl -p0e 's/> *</></g' | grep '<property name="REPORT_DIR" value="/var/log/rudder/compliance" />' > /dev/null | |||
There was a problem hiding this comment.
Please don't include the literal path for the reports in your migration test. Doing this means that if a user changes the path (this is a config file after all, it wouldn't be surprising for a user to do so), then we will run the migration again.
Replace the path with "[^"]+" should do it (testing required!)
|
I push the fix, tell me before merge so that i can rebase everything into one commit |
|
Looks good to me ! Approved. |
Kegeruneku
pushed a commit
that referenced
this pull request
Jan 21, 2013
Fixes #3195 : Add migration script to add non compliant report logger to...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... logback.xml
http://www.rudder-project.org/redmine/issues/3195