Fixes #11935: Broken build on rhel #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
peckpeck
force-pushed
the
bug_11935/broken_build_on_rhel
branch
from
070cef1
to
efcbd4a
Compare
amousset
reviewed
Jan 9, 2018
| @@ -131,6 +131,14 @@ Requires: kernel-utils | |||
| Requires: dmidecode | |||
| %endif | |||
|
|
|||
| # https fails on old distro because they don't support modern certificates (namely rhel3 and sles10) | |||
There was a problem hiding this comment.
don't we need to the the default value to true?
There was a problem hiding this comment.
it can be anything, the default within the makefile is true since we compare to the litteral "false"
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11935