Fixes #11950: Add a rudder-server init script that will replace the rudder script on server #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
ust_11950/add_a_rudder_server_init_script_that_will_replace_the_rudder_script_on_server
branch
from
661a4c0
to
3c5ff72
Compare
|
Commit modified |
amousset
force-pushed
the
ust_11950/add_a_rudder_server_init_script_that_will_replace_the_rudder_script_on_server
branch
from
3c5ff72
to
b59e7ba
Compare
|
PR rebased |
peckpeck
requested changes
Jan 15, 2018
| true | ||
|
|
||
| install: | ||
| mkdir -p $(DESTDIR)/etc/init.d/ |
| RUDDER_DIR = /opt/rudder | ||
| DESTDIR = $(CURDIR)/target | ||
| INSTALL_DIR = $(DESTDIR)$(RUDDER_DIR) | ||
|
|
There was a problem hiding this comment.
You should probably add GET too
|
|
||
| # Init files | ||
| ifneq (true,$(NO_INIT)) | ||
| $(INSTALL) -m 755 rudder-server.init $(DESTDIR)/etc/init.d/rudder-server |
There was a problem hiding this comment.
There is no reference to this file in the specfile/debianrules how does it suddenly appear here
| ;; | ||
|
|
||
| upgrade) | ||
| exit 0 |
| @@ -1,2 +1,2 @@ | |||
| opt/rudder/etc | |||
| opt/rudder/bin | |||
| opt/rudder/bin | |||
There was a problem hiding this comment.
missing newline at end of file
| echo "Rudder is now installed but not configured." | ||
| echo "Please run /opt/rudder/bin/rudder-init" | ||
| echo "************************************************************" | ||
| fi |
| then | ||
| if type chkconfig > /dev/null | ||
| then | ||
| chkconfig --add rudder-server |
There was a problem hiding this comment.
You should add an || true since the rudder-agent package may just have done the same thing.
(and add it to the agent package too)
There was a problem hiding this comment.
Not on rudder-server, which is managed completely in rudder-server-root
…udder script on server
amousset
force-pushed
the
ust_11950/add_a_rudder_server_init_script_that_will_replace_the_rudder_script_on_server
branch
from
b59e7ba
to
43d7ded
Compare
|
PR replaced by #1449 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11950