Fixes #4016,#4010: Use the unified apache logging directory in RHEL #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if [ -d %{rudderlogdir}/httpd ]; then | ||
| echo -n "INFO: Old logging directory detected (%{rudderlogdir}/httpd), migrating to %{rudderlogdir}/apache2..." | ||
| mkdir -p %{rudderlogdir}/apache2/migrated | ||
| cp -a %{rudderlogdir}/httpd/* %{rudderlogdir}/apache2/migrated/ |
There was a problem hiding this comment.
Be careful - copying the logs can take up a lot of extra disk space, and therefore may fail. How about we mv instead, then you can just "rmdir" the remaining directory (avoiding a rm -rf ...)?
|
Please also add a migration script to modify the paths in the apache config file. |
|
PR updated. |
Kegeruneku
pushed a commit
that referenced
this pull request
Oct 14, 2013
…fied_apache_logging_directory_in_rhel_packaging Fixes #4016,#4010: Use the unified apache logging directory in RHEL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://www.rudder-project.org/redmine/issues/4016
To be merged in master