Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #12285: Change defaults for embedding xml and yaml #1536

Conversation

peckpeck
Copy link
Member

# default: embed libyaml
ifneq (true,$(USE_SYSTEM_YAML))
# default: do not embed libyaml
ifeq (true,$(USE_SYSTEM_YAML))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not ifneq ?

@peckpeck
Copy link
Member Author

Commit modified

@peckpeck peckpeck force-pushed the arch_12285/change_defaults_for_embedding_xml_and_yaml branch from 71e4440 to aa460d1 Compare March 27, 2018 15:47
@peckpeck
Copy link
Member Author

Commit modified

@peckpeck peckpeck force-pushed the arch_12285/change_defaults_for_embedding_xml_and_yaml branch from aa460d1 to a6e2795 Compare March 27, 2018 15:48
%define use_system_perl false
%define use_system_openssl false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new dependencies

@peckpeck
Copy link
Member Author

Commit modified

@peckpeck peckpeck force-pushed the arch_12285/change_defaults_for_embedding_xml_and_yaml branch from a6e2795 to 656729d Compare March 27, 2018 15:51
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 656729d into Normation:branches/rudder/4.3 Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants