-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #12285: Change defaults for embedding xml and yaml #1536
Merged
Normation-Quality-Assistant
merged 1 commit into
Normation:branches/rudder/4.3
from
peckpeck:arch_12285/change_defaults_for_embedding_xml_and_yaml
Mar 27, 2018
Merged
Fixes #12285: Change defaults for embedding xml and yaml #1536
Normation-Quality-Assistant
merged 1 commit into
Normation:branches/rudder/4.3
from
peckpeck:arch_12285/change_defaults_for_embedding_xml_and_yaml
Mar 27, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
Mar 27, 2018
rudder-agent/SOURCES/Makefile
Outdated
# default: embed libyaml | ||
ifneq (true,$(USE_SYSTEM_YAML)) | ||
# default: do not embed libyaml | ||
ifeq (true,$(USE_SYSTEM_YAML)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not ifneq ?
Commit modified |
71e4440
to
aa460d1
Compare
Commit modified |
aa460d1
to
a6e2795
Compare
amousset
reviewed
Mar 27, 2018
%define use_system_perl false | ||
%define use_system_openssl false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new dependencies
Commit modified |
a6e2795
to
656729d
Compare
amousset
approved these changes
Mar 27, 2018
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12285