Fixes #12634: .pyc file are not cleand up during postinst #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
amousset
force-pushed
the
bug_12634/pyc_file_are_not_cleand_up_during_postinst
branch
from
87278b7
to
960fd3c
Compare
| @@ -247,6 +247,10 @@ fi | |||
| # Enable mod_wsgi using a2enmod | |||
| a2enmod wsgi >/dev/null 2>&1 | |||
|
|
|||
| # Remove .pyc files to ensure we don't end up with outdated files | |||
| rm -f %{installdir}/tools/ncf.pyc | |||
| rm -f %{installdir}/tools/ncf_constraints.pyc | |||
There was a problem hiding this comment.
you should also rm ncf_rudder.pyc
There was a problem hiding this comment.
(in fact i would do
find %{installdir}/tools -name "*.pyc" -exec rm -f {} \;
There was a problem hiding this comment.
Hmm, in fact ncf_rudder does not make a pyc ..., i would still do a find :)
|
We should create another issue to make sure we never forget a .pyc file in any packages. |
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/12634