Fixes #14006: Move rudder-slapd to a systemd unit #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
force-pushed
the
arch_14006/move_rudder_slapd_to_a_systemd_unit
branch
from
878904d
to
c1d9076
Compare
|
Commit modified |
peckpeck
reviewed
Dec 20, 2018
| %config(noreplace) /opt/rudder/etc/openldap/slapd.conf | ||
| /etc/init.d/rudder-slapd | ||
| /usr/lib/systemd/system/rudder-slapd.service | ||
| /opt/rudder/etc |
There was a problem hiding this comment.
you need to add the package-script
amousset
force-pushed
the
arch_14006/move_rudder_slapd_to_a_systemd_unit
branch
from
c1d9076
to
02a895b
Compare
|
Commit modified |
peckpeck
reviewed
Dec 20, 2018
| sed -i '/^[ \t]*argsfile/d' "${LDAP_CONF}" | ||
|
|
||
| # Migration from pre-5.1, moving settings to slapd.conf | ||
| if [ -f /etc/default/rudder-slapd ]; then |
There was a problem hiding this comment.
will the file still be there in a postinst ?
There was a problem hiding this comment.
good question, it seems not, I'll make a copy of the file in preinst to make sure we don't miss it in case of a purge.
amousset
force-pushed
the
arch_14006/move_rudder_slapd_to_a_systemd_unit
branch
from
02a895b
to
1d07fe2
Compare
|
Commit modified |
amousset
force-pushed
the
arch_14006/move_rudder_slapd_to_a_systemd_unit
branch
from
1d07fe2
to
c58cdb2
Compare
|
Commit modified |
peckpeck
approved these changes
Dec 20, 2018
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/14006