Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10623: Hooks content/permissions are changed during Rudder upgrade (for ex /opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check is replaced) #2063

Conversation

peckpeck
Copy link
Member

…rade (for ex /opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check is replaced)
@Normation-Quality-Assistant
Copy link
Contributor

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/5.0' set up to track remote branch 'branches/rudder/5.0' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/5.0'.
Already up to date.
Already up to date.
[...]

-- stderr --
From github.com:peckpeck/rudder-packages
 * [new branch]        bug_10623/hooks_content_permissions_are_changed_during_rudder_upgrade_for_ex_opt_rudder_etc_hooks_d_policy_generation_node_ready_10_cf_promise_check_is_replaced -> bug_10623/hooks_content_permissions_are_changed_during_rudder_upgrade_for_ex_opt_rudder_etc_hooks_d_policy_generation_node_ready_10_cf_promise_check_is_replaced_pr
Switched to branch 'branches/rudder/5.0'
Switched to a new branch '5.0_test'
+ find ./rudder-server-relay/SOURCES/relay-api/relay_api -name '*.py'
+ xargs pylint -E --disable=C,R,no-member,no-name-in-module --persistent=n
No config file found, using default configuration

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-packages/pull/2063 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/14655/console)

@peckpeck
Copy link
Member Author

OK, merging this PR

@peckpeck peckpeck merged commit e1fed5f into Normation:branches/rudder/5.0 Sep 10, 2019
@peckpeck peckpeck deleted the bug_10623/hooks_content_permissions_are_changed_during_rudder_upgrade_for_ex_opt_rudder_etc_hooks_d_policy_generation_node_ready_10_cf_promise_check_is_replaced branch July 13, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants