Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #15687: Hooks content/permissions are changed during Rudder upgrade (for ex /opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check is replaced) #2066

Conversation

@peckpeck
Copy link
Contributor

commented Sep 11, 2019

Fixes #15687: Hooks content/permissions are changed during Rudder upg…
…rade (for ex /opt/rudder/etc/hooks.d/policy-generation-node-ready/10-cf-promise-check is replaced)
@Normation-Quality-Assistant

This comment has been minimized.

Copy link

commented Sep 11, 2019

This PR breaks qa-test

-- stdout -- 
Branch 'branches/rudder/5.0' set up to track remote branch 'branches/rudder/5.0' from 'NRM'.
Your branch is up to date with 'NRM/branches/rudder/5.0'.
Already up to date.
Already up to date.
[...]

-- stderr --
From github.com:peckpeck/rudder-packages
 * [new branch]        bug_15687/hooks_content_permissions_are_changed_during_rudder_upgrade_for_ex_opt_rudder_etc_hooks_d_policy_generation_node_ready_10_cf_promise_check_is_replaced -> bug_15687/hooks_content_permissions_are_changed_during_rudder_upgrade_for_ex_opt_rudder_etc_hooks_d_policy_generation_node_ready_10_cf_promise_check_is_replaced_pr
Switched to branch 'branches/rudder/5.0'
Switched to a new branch '5.0_test'
+ find ./rudder-server-relay/SOURCES/relay-api/relay_api -name '*.py'
+ xargs pylint -E --disable=C,R,no-member,no-name-in-module --persistent=n
No config file found, using default configuration

You should run ./qa-test in your repository to make sure it works.
You can also run rudder-dev merge https://github.com/Normation/rudder-packages/pull/2066 --test to test with upmerging.
After this, you can remove the qa: Can't merge ta
-- Your faithful QA (https://ci.normation.com/jenkins/job/merge-accepted-pr/14697/console)

@peckpeck

This comment has been minimized.

Copy link
Contributor Author

commented Sep 11, 2019

OK, merging this PR

@peckpeck peckpeck merged commit 516dd96 into Normation:branches/rudder/5.0 Sep 11, 2019

1 check passed

ci/test-quality-assistant Quality-Assistant
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.