Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16085: rudder-api-client packaging untar the sources two times #2130

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Oct 30, 2019

@amousset
Copy link
Member

you also need to edit the rules file

@Fdall
Copy link
Contributor Author

Fdall commented Oct 30, 2019

PR updated with a new commit

@@ -40,6 +35,10 @@ binary-arch: install
dh_testdir
dh_testroot
dh_installchangelogs
#
# Force python everywhere in 5.0
find . -type f | xargs sed -i '1,1s|#!/usr/bin/python3|#!/usr/bin/python|'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into the build target

@Fdall
Copy link
Contributor Author

Fdall commented Oct 30, 2019

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-packages/pull/2130
-- Your faithful QA
Kant merge: "Two things awe me most, the starry sky above me and the moral law within me."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/16562/console)

@Fdall
Copy link
Contributor Author

Fdall commented Oct 30, 2019

OK, squash merging this PR

@Fdall Fdall force-pushed the bug_16085/rudder_api_client_packaging_untar_the_sources_two_times branch from fd583f7 to ce1d496 Compare October 30, 2019 15:31
@Fdall Fdall merged commit ce1d496 into Normation:branches/rudder/5.0 Oct 30, 2019
@Fdall
Copy link
Contributor Author

Fdall commented Oct 30, 2019

OK, merging this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants