Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16745: when upgrding rudder from 5.0 to 6.0, the rudder-pkg restaure pkg cannot restart correctly Jetty, so rudder-upgrade doesn't checkk compatibility, and rudder cannot start #2202

Conversation

ncharles
Copy link
Member

# Restore the plugins and checking them
if [ -f /tmp/rudder-plugins-upgrade ]
then
/opt/rudder/bin/rudder-pkg plugin restore-status < /tmp/rudder-plugins-upgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace '/opt/rudder/bin/rudder-pkg' by calls to 'rudder package' command please ?

@@ -168,6 +162,13 @@ echo "Done"
# Adjust permissions on /var/rudder/configuration-repository
/opt/rudder/bin/rudder-fix-repository-permissions >> ${LOG_FILE}

# Restore the plugins and checking them
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont get this. Currently we restore the status, then rudder-upgrade runs check-compatibility and rudder-postupgrade. Why doing it again just after?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parent ticket change the order, but it wasn't such a great idea

@ncharles
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-packages/pull/2202
-- Your faithful QA
Kant merge: "All our knowledge begins with the senses, proceeds then to the understanding, and ends with reason. There is nothing higher than reason."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/20591/console)

@ncharles
Copy link
Member Author

OK, squash merging this PR

…staure pkg cannot restart correctly Jetty, so rudder-upgrade doesn't checkk compatibility, and rudder cannot start
@ncharles ncharles force-pushed the bug_16745/when_upgrding_rudder_from_5_0_to_6_0_the_rudder_pkg_restaure_pkg_cannot_restart_correctly_jetty_so_rudder_upgrade_doesn_t_checkk_compatibility_and_rudder_cannot_start branch from 7f332c6 to 93cf813 Compare February 21, 2020 15:23
@ncharles ncharles merged commit 93cf813 into Normation:branches/rudder/6.0 Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants