New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #16745: when upgrding rudder from 5.0 to 6.0, the rudder-pkg restaure pkg cannot restart correctly Jetty, so rudder-upgrade doesn't checkk compatibility, and rudder cannot start #2202
Conversation
# Restore the plugins and checking them | ||
if [ -f /tmp/rudder-plugins-upgrade ] | ||
then | ||
/opt/rudder/bin/rudder-pkg plugin restore-status < /tmp/rudder-plugins-upgrade |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you replace '/opt/rudder/bin/rudder-pkg' by calls to 'rudder package' command please ?
@@ -168,6 +162,13 @@ echo "Done" | |||
# Adjust permissions on /var/rudder/configuration-repository | |||
/opt/rudder/bin/rudder-fix-repository-permissions >> ${LOG_FILE} | |||
|
|||
# Restore the plugins and checking them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont get this. Currently we restore the status, then rudder-upgrade runs check-compatibility
and rudder-postupgrade
. Why doing it again just after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parent ticket change the order, but it wasn't such a great idea
PR updated with a new commit |
This PR is not mergeable to upper versions. |
OK, squash merging this PR |
…staure pkg cannot restart correctly Jetty, so rudder-upgrade doesn't checkk compatibility, and rudder cannot start
7f332c6
to
93cf813
Compare
https://issues.rudder.io/issues/16745