Fixes #17128: review index for LDAP #2249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fanf
reviewed
Apr 24, 2020
| @@ -61,6 +61,9 @@ maxsize 107374182400 | |||
|
|
|||
| # Indices to maintain | |||
| index objectClass eq | |||
| index cn eq | |||
| index softwareVersion eq | |||
| index directiveId eq | |||
|
|
|||
There was a problem hiding this comment.
Because this subject is hard to check but in the long run, I propose to add in comments why/how each elements were tested (and especially if the were not). Ex:
# from https://issues.rudder.io/issues/17128
index cn eq
index softwareVersion eq
index directiveId eq
# this one leads to an error, not explored yet: https://issues.rudder.io/issues/17128#note-8
# index nodeGroupId eq #extremelly frequent!
# appear in candidate but not tested yet, sorted by number, more in top:
# index nodeId eq
# index osName eq
# index agentName eq
# index isDynamic eq
# index isSystem eq
# index policyServerId eq
# index software eq
fanf
approved these changes
Apr 24, 2020
|
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17128