Fixes #17217: Replace node-to-relay script from rudder-package #2251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This script should only be in the plugin now |
amousset
reviewed
Apr 24, 2020
| ${ECHO} "ERROR: Cannot find the machine (inventory not found), aborting." | ||
| exit 1 | ||
| fi | ||
| echo "INFO: Please use 'rudder server node-to-relay <UUID>' command" |
There was a problem hiding this comment.
This command is deprecated, please ...
|
PR updated with a new commit |
|
Commit modified |
ElaadF
force-pushed
the
ust_17217/replace_node_to_relay_script_from_rudder_package
branch
from
d93b4db
to
9836f7c
Compare
amousset
reviewed
Apr 24, 2020
| echo "INFO: This command is deprecated, please use 'rudder server node-to-relay <UUID>'" | ||
| echo -e "Running: rudder server node-to-relay $@ \n" | ||
| rudder server node-to-relay $@ | ||
| code=$? |
There was a problem hiding this comment.
no need for check here, let the new script do the error handling
|
PR updated with a new commit |
amousset
approved these changes
Apr 24, 2020
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
ElaadF
force-pushed
the
ust_17217/replace_node_to_relay_script_from_rudder_package
branch
from
e6dd142
to
e93408f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/17217