Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #17536: Change all python3 scripts to python2 on rhel7 at build time #2299

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented May 27, 2020

@Fdall Fdall requested a review from peckpeck May 27, 2020 13:59
@@ -307,6 +307,11 @@ FusionInventory.

cd %{_sourcedir}

# rhel7 doesn't have python 3 so we force python2 instead
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make build include a source get so this one should go after it

@Fdall
Copy link
Contributor Author

Fdall commented May 28, 2020

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-packages/pull/2299
-- Your faithful QA
Kant merge: "Live your life as though your every act were to become a universal law."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/25339/console)

@Fdall
Copy link
Contributor Author

Fdall commented Jun 1, 2020

OK, squash merging this PR

@Fdall Fdall force-pushed the bug_17536/change_all_python3_scripts_to_python2_on_rhel7_at_build_time branch from 1a5f31b to 64c7853 Compare June 1, 2020 13:30
@Fdall Fdall merged commit 64c7853 into Normation:branches/rudder/6.0 Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants