Fixes #18144: Remove rsyslog dependency from 7.0 #2359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peckpeck
reviewed
Aug 26, 2020
rudder-webapp/SOURCES/Makefile
Outdated
| @@ -188,7 +187,6 @@ install: build initial-promises initial-ncf | |||
| install -m 640 slapd.conf $(DESTDIR)/opt/rudder/etc/openldap/slapd.conf | |||
| install -m 644 $(WEBAPPDIR)/ldap-inventory/inventory-repository/src/main/resources/ldap/inventory.schema $(DESTDIR)/opt/rudder/etc/openldap/schema/ | |||
| install -m 644 $(CORE_RESOURCES)/ldap/rudder.schema $(DESTDIR)/opt/rudder/etc/openldap/schema/ | |||
| install -m 644 rsyslog/rudder-slapd.conf $(DESTDIR)/etc/rsyslog.d/rudder-slapd.conf | |||
There was a problem hiding this comment.
don't we need to also remove that at postinst time ?
There was a problem hiding this comment.
This file is for slapd logs and not linked to reporting
There was a problem hiding this comment.
(it is not removed anymore in this PR)
amousset
force-pushed
the
arch_18144/remove_rsyslog_dependency_from_7_0
branch
from
37e8300
to
3a55380
Compare
|
Commit modified |
|
PR updated with a new commit |
peckpeck
approved these changes
Feb 8, 2021
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
amousset
force-pushed
the
arch_18144/remove_rsyslog_dependency_from_7_0
branch
from
0ed10d8
to
7c27cba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/18144