Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #17878: All plugins are disabled after a minor upgrade #2368

Merged
merged 1 commit into from Oct 22, 2020
Merged

Fixes #17878: All plugins are disabled after a minor upgrade #2368

merged 1 commit into from Oct 22, 2020

Conversation

VinceMacBuche
Copy link
Member

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@VinceMacBuche VinceMacBuche changed the base branch from branches/rudder/6.1 to branches/rudder/6.2 October 9, 2020 09:48
ncharles
ncharles reviewed Oct 21, 2020
View reviewed changes
rudder-webapp/SOURCES/rudder-upgrade Outdated
#rudder package check-compatibility
rudder package plugin disable-all
rudder package rudder-postupgrade
rudder package licenses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a STEP

ncharles
ncharles reviewed Oct 21, 2020
View reviewed changes
rudder-webapp/SOURCES/rudder-upgrade
# are not compatible
#rudder package check-compatibility
rudder package plugin disable-all
rudder package rudder-postupgrade
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

STEP="Upgrade all plugins if necessary"

ncharles
ncharles requested changes Oct 21, 2020
View reviewed changes
Copy link
Member

@ncharles ncharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is necessary to had a STEP name for error handling

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

amousset
amousset reviewed Oct 21, 2020
View reviewed changes
rudder-webapp/SOURCES/rudder-upgrade Outdated
rudder package plugin disable-all
rudder package rudder-postupgrade
STEP="Upgrade all plugins"
rudder package licenses || true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an if rudder package test-connection would allow displaying error messages only when needed (i.e. connection works but plugin management fails)

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

amousset
amousset reviewed Oct 21, 2020
View reviewed changes
rudder-webapp/SOURCES/rudder-upgrade Outdated
rudder package rudder-postupgrade
STEP="Upgrade all plugins"
if rudder-package check-connection >/dev/null 2>&1 ; then
rudder package licenses || true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for licences command anymore

@VinceMacBuche
Copy link
Member Author

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

This PR is not mergeable to upper versions.
Since it is "Ready for merge" you must merge it by yourself using the following command:
rudder-dev merge https://github.com/Normation/rudder-packages/pull/2368
-- Your faithful QA
Kant merge: "Science is organized knowledge. Wisdom is organized life."
(https://ci.normation.com/jenkins/job/merge-accepted-pr/31394/console)

@fanf
Copy link
Member

fanf commented Oct 22, 2020

OK, squash merging this PR

@fanf fanf force-pushed the bug_17878/all_plugins_are_disabled_after_a_minor_upgrade branch from d937540 to 3ed1d8f Compare October 22, 2020 10:09
@fanf fanf merged commit 3ed1d8f into Normation:branches/rudder/6.2 Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles requested changes

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
qa: Can't merge Ready for merge
Projects
None yet
Milestone
No milestone
5 participants
@VinceMacBuche @Normation-Quality-Assistant @fanf @ncharles @amousset