Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #21151: Make rudder-jetty.conf and default rudder-jetty compatible with JVM 11 and 17 #2606

Merged
merged 1 commit into from
May 30, 2022
Merged

Fixes #21151: Make rudder-jetty.conf and default rudder-jetty compatible with JVM 11 and 17 #2606

merged 1 commit into from
May 30, 2022

Conversation

fanf
Copy link
Member

@fanf fanf commented May 23, 2022 •
edited
Loading

https://issues.rudder.io/issues/21151

Main changes:

  • use G1GC by default
    • with string deduplication
    • and touch pages at launch
  • add high level, not verbose GC info (always) in /var/log/rudder/webapp/jvm-gc.log (rotation: 5 files, 50M each)
  • let user be able to override GC log level (with a suitable example for debug metrics in comments)
  • notice in comment of the overridding file what is used by default

@fanf fanf requested a review from amousset May 23, 2022 14:43
@peckpeck
Copy link
Member

You should make ruder-jetty.conf not a conffile and test an upgrade from the previous version with a modified conf to make sure the file is replaced both with RPM and DEB

@fanf
Copy link
Member Author

fanf commented May 30, 2022

PR updated with a new commit

amousset
amousset reviewed May 30, 2022
View reviewed changes
rudder-server/debian/conffiles Outdated
@@ -1,4 +1,4 @@
/opt/rudder/etc/rudder-jetty.conf
/etc/default/rudder-jetty
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need, everything in /etc is automatically flagged as conffile

@fanf
Copy link
Member Author

fanf commented May 30, 2022

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_21151/make_rudder_jetty_conf_and_default_rudder_jetty_compatible_with_jvm_11_and_17 branch from b3c67df to 61c4b52 Compare May 30, 2022 13:36
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit 61c4b52 into Normation:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncharles ncharles ncharles left review comments

@amousset amousset amousset approved these changes

Assignees
No one assigned
Labels
Ready for merge Trigger test
Projects
None yet
Milestone
No milestone
5 participants
@fanf @peckpeck @Normation-Quality-Assistant @ncharles @amousset