Fixes #21086: Create a package for people having an external DB #2608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amousset
reviewed
May 24, 2022
rudder-external-db/Makefile
Outdated
| .DEFAULT_GOAL := build | ||
| # Used on debian to redirect calls to final Makefile so dh auto commands work | ||
| %: | ||
| make -C BUILD/rudder/relay/sources/ --debug $@ |
There was a problem hiding this comment.
probably not the right command
|
PR updated with a new commit |
amousset
reviewed
May 25, 2022
| @@ -0,0 +1,22 @@ | |||
| # Please fill the configuration to make sure Rudder serveur will be properly installed | |||
There was a problem hiding this comment.
Suggested change
| # Please fill the configuration to make sure Rudder serveur will be properly installed | |
| # Please fill the configuration to make sure Rudder server will be properly installed |
amousset
reviewed
May 25, 2022
| @@ -0,0 +1,22 @@ | |||
| # Please fill the configuration to make sure Rudder serveur will be properly installed | |||
| # Please ask your database administrator for those informations. | |||
There was a problem hiding this comment.
Suggested change
| # Please ask your database administrator for those informations. | |
| # Please ask your database administrator for this information. |
amousset
approved these changes
May 25, 2022
amousset
reviewed
May 25, 2022
| @@ -79,7 +79,7 @@ Obsoletes: rudder-reports < 7.2 | |||
|
|
|||
| Requires: %(../format-dependencies rpm %{old_epoch}:%{real_version} rudder-agent) | |||
| Requires: %(../format-dependencies rpm %{real_version} rudder-relay) | |||
| Requires: postgresql-server >= 10.3, %{apache}, %{apache_tools}, git-core, iproute, rsync, openssl, %{ldap_clients}, curl, acl, rudder-api-client | |||
| Requires: (postgresql-server >= 10.3 or rudder-external-db), %{apache}, %{apache_tools}, git-core, iproute, rsync, openssl, %{ldap_clients}, curl, acl, rudder-api-client | |||
There was a problem hiding this comment.
is it supported on amazon linux 2?
|
PR updated with a new commit |
amousset
approved these changes
May 25, 2022
|
OK, squash merging this PR |
Normation-Quality-Assistant
force-pushed
the
arch_21086/create_a_package_for_people_having_an_external_db
branch
from
1e5371a
to
42a54f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/21086