Fixes #22689: silent rudder-upgrade failure / plugins were not upgraded when upgrading from 7.2.5 to 7.3.1~nightly #2723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
reviewed
Apr 26, 2023
| then | ||
| echo "INFO: Existing database detected, skipping database creation" | ||
| CREATE_DB="false" | ||
| fi |
|
PR updated with a new commit |
amousset
approved these changes
May 3, 2023
|
OK, squash merging this PR |
…ed when upgrading from 7.2.5 to 7.3.1~nightly
Normation-Quality-Assistant
force-pushed
the
bug_22689/silent_rudder_upgrade_failure_plugins_were_not_upgraded_when_upgrading_from_7_2_5_to_7_3_1_nightly
branch
from
08b4fae
to
1956312
Compare
| CREATE_DB="false" | ||
| else | ||
| USER=$(grep rudder.jdbc.username /opt/rudder/etc/rudder-web.properties) | ||
| CHK_PG_USER=$(su postgres -c "psql -t -c \"select count(1) from pg_user where usename = '${USERNAME}'\"") |
There was a problem hiding this comment.
USERNAME variable is not created, it is USER. And the value of USER variable is wrong the command gives
grep rudder.jdbc.username /opt/rudder/etc/rudder-web.properties
rudder.jdbc.username=rudder
on my rudder server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/22689
Replacing previous PR: #2722