Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #23186: Rudder Server 7.3.4 doesn't install on SLES 15 SP4 #2794

Conversation

ncharles
Copy link
Member

@ncharles ncharles commented Aug 1, 2023

https://issues.rudder.io/issues/23186

On SLES15, the fresh installation fails, because postgresql is not started by default
The change cannot simply be "start postgresql" because:

  • On RHEL like, we need to initdb
  • with a remote database, we don't need a local postgres
  • the script is a total mess

So i massively rewrote it to:

  • detect if database is local or not
  • have 2 distinct paths for local and remote database, to untangle everything
  • try to not reinit database at each upgrade

@ncharles ncharles requested a review from amousset August 1, 2023 10:58
@ncharles
Copy link
Member Author

ncharles commented Aug 1, 2023

This is not tested yet

@ncharles
Copy link
Member Author

ncharles commented Aug 1, 2023

PR updated with a new commit

@Normation-Quality-Assistant
Copy link
Contributor

OK, squash merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant force-pushed the bug_23186/rudder_server_7_3_4_doesn_t_install_on_sles_15_sp4 branch from 442f029 to ebe46c7 Compare August 1, 2023 11:30
@Normation-Quality-Assistant Normation-Quality-Assistant merged commit ebe46c7 into Normation:branches/rudder/7.3 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants