Fixes #4789: fix expression to compute run_interval in #311
Conversation
| @@ -89,7 +89,7 @@ fi | |||
|
|
|||
|
|
|||
| RUN_INTERVAL=`cat /var/rudder/cfengine-community/inputs/run_interval` | |||
| CHECK_INTERVAL=`expr ${RUN_INTERVAL} * 2` | |||
| CHECK_INTERVAL=`expr ${RUN_INTERVAL} "*" 2` | |||
There was a problem hiding this comment.
I'm not sure about this workaround. My reflex would be to escape the * which is being interpreted by the shell, like this:
CHECK_INTERVAL=`expr ${RUN_INTERVAL} \* 2`
There was a problem hiding this comment.
Do you have any indication that your approach has advantages over this?
There was a problem hiding this comment.
I had no idea why escaping with " would be better, I only followed one guide that explain me to use double quote ... http://rcsg-gsir.imsb-dsgi.nrc-cnrc.gc.ca/documents/bourne/node32.html
But in fact using \ seems better ...
" is better to escape a whole series of character, here there is only one, so using \ is better
There was a problem hiding this comment.
And just tested, no problem using backslash
There was a problem hiding this comment.
And backslash works on aix too
check-rudder-agent
|
Made new commit with |
…k-rudder-agent Fixes #4789: fix expression to compute run_interval in
check-rudder-agent
http://www.rudder-project.org/redmine/issues/4789