Bug 4613/dev/prevent duplicate cf execd #331
Conversation
| NB_CF_EXECD_RUNNING=`echo "${CF_EXECD_RUNNING}" | grep -v ^$ | wc -l` | ||
| if [ ${NB_CF_EXECD_RUNNING} -gt 1 ]; then | ||
| echo -n "WARNING: Too many instance of CFEngine cf-execd processes running. Killing them..." | ||
| echo "${CF_EXECD_RUNNING}" | awk 'BEGIN { OFS=" "} {print $2 }' | xargs kill -9 || true |
There was a problem hiding this comment.
What! What's with the "kill -9"? That's very brutal, I don't see any call for that...
I don't know why you have used this because no comments explain your intent. I see two options here:
- You have a good reason to "use the force". Please add a comment in the script explaining it.
- You don't have a reason. Then use a plain kill instead.
There was a problem hiding this comment.
When several cf-execd are running, simple kill don't kill them, only -9 can stop them)
There was a problem hiding this comment.
I'm afraid you misread me: the comment should appear in the script, not here! This needs to be understandable and maintanable by the future us :)
There was a problem hiding this comment.
OK, GitHub is being weird. I see that you already did this by re-reading the full diff, but the diff above still displays the old code, and isn't marked as "outdated" like usual.
So this looks good, thanks.
|
PR has been updated |
…cf-execd Bug 4613/dev/prevent duplicate cf execd
No description provided.