Fixes #4997: check-rudder-agent can now handle missing run_interval file #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that this is a good approach. Creating a file in the inputs directory is at best a temporary workaround, and we know that on the first cf-agent run, it will get removed. I think this should be fixed directly at the source: in the check-rudder-agent script. Something like "if the file exists, read in the interval, if not assume interval=5". @VinceMacBuche, can you rework this please? |
VinceMacBuche
changed the title
|
Ok ! I updated the pull request! now check-rudder-agent handle the missing file |
| # File does not exists, use default value 5 | ||
| RUN_INTERVAL=5 | ||
| fi | ||
|
|
||
| RUN_INTERVAL=`cat /var/rudder/cfengine-community/inputs/run_interval` |
There was a problem hiding this comment.
You need to remove this line...
There was a problem hiding this comment.
me so dumb ... removed the line
jooooooon
added a commit
that referenced
this pull request
Jun 11, 2014
…_not_exists Fixes #4997: check-rudder-agent can now handle missing run_interval file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://www.rudder-project.org/redmine/issues/4997