Fixes #5198: Do not use stat on AIX in check-rudder-agent, but istat ins... #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| CF_LOCK_SIZE=`stat -c%s "${CFE_DIR}/state/cf_lock.tcdb"` | ||
|
|
||
| if [ "z${OS_FAMILY}" = "zAIX" ]; then | ||
| CF_LOCK_SIZE=`istat "${CFE_DIR}/state/cf_lock.tcdb" | grep Length | sed "s%^.*Length \([0-9]*\) bytes%\1%"` |
There was a problem hiding this comment.
I would be happier if this regex contained a .*$ at the end, so that we were SURE we were only getting a number out of this.
|
Aside from this looks good. Please fix and self merge. |
|
I also changed to way we choose the database (.tcdb suffix) to avoid duplication |
| @@ -135,7 +139,7 @@ check_and_fix_cfengine_processes() { | |||
|
|
|||
|
|
|||
| # Check for anomalous number of CFEngine processes | |||
| # If there are more than 8 agent/executor processes, we should kill them, and purge the tcdb database | |||
| # If there are more than 8 agent/executor processes, we should kill them, and purge the state database | |||
There was a problem hiding this comment.
It's not the state db, it's the lock db. These are 2 different things.
|
Looks good. Merge when ready. And please adapt for LMDB in 2.11+ |
Kegeruneku
pushed a commit
that referenced
this pull request
Jul 2, 2014
…n_aix_no_stat Fixes #5198: Do not use stat on AIX in check-rudder-agent, but istat ins...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...tead
Ticket: http://www.rudder-project.org/redmine/issues/5198
To be merged in 2.10