Fixes #6477: Create a script to sign files using openssl on unix #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| FILE="$1" | ||
| if [ ! -e "${FILE}" ] | ||
| then | ||
| echo "Cannot sign: The file ${FILE} doesn't exist" |
|
I'd rather name this utility signature and not signature.sh :) the suffix is not desirable here nor needed ! Let the kernel use its shebang magic to handle the rest :p |
| else | ||
| echo "ERROR: openssl binary is missing !" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Why not use:
if ! type openssl 2> /dev/null
then
echo "ERROR: openssl binary is missing !"
exit 1
fi
You'd avoid a useless "true"
|
There will be a signature.cmd for windows too, the .sh was here to explicitly distinguish which one will be for wich environment |
peckpeck
force-pushed
the
dev_6477/create_a_script_to_sign_files_using_openssl_on_unix
branch
from
a0896a9
to
4c133a0
Compare
|
PR updated |
|
That's a good reason ! |
|
Would you be kind enough to retarget this PR for 3.1 ? |
|
Also this script should be able to try to use Rudder's bundled OpenSSL version if no system one is available (/opt/rudder/bin/openssl) |
…date_rudder_agent_thin_patches Fixes #6355: Update rudder-agent-thin Debian packages
…elinux_compatibility Fixes #6517: Add initial SELinux support
peckpeck
force-pushed
the
dev_6477/create_a_script_to_sign_files_using_openssl_on_unix
branch
from
4c133a0
to
2b00078
Compare
|
PR replaced by #644 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR replaced by #644