Fixes #6594: Do not run update-rc.d when it is not needed #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +84,7 @@ binary-arch: install | |||
| # dh_installlogrotate | |||
| # dh_installmime | |||
| # dh_python | |||
| dh_installinit --update-rcd-params=disable -R --name=rudder-slapd # restart after upgrade (instead of stop, upgrade, start) | |||
| # dh_installinit --no-start # restart after upgrade (instead of stop, upgrade, start) | |||
There was a problem hiding this comment.
The comment doesn't match the code
There was a problem hiding this comment.
Does this work when there is no service at all ?
There was a problem hiding this comment.
No, this is why it is commented :)
Kegeruneku
force-pushed
the
bug_6594/int/6594_no_update_rc_d_when_unneeded
branch
from
79dc6ed
to
3ef73b4
Compare
|
OK Good |
peckpeck
added a commit
that referenced
this pull request
May 19, 2015
…c_d_when_unneeded Fixes #6594: Do not run update-rc.d when it is not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: http://www.rudder-project.org/redmine/issues/6594
To be merged in 3.1