Fixes #6911: Remove migration process from old version to 3.1 #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if ! perl -p0e 's/\n//g' < /opt/rudder/etc/logback.xml | perl -p0e 's/<!--.(?:(?!-->).)*-->//g' | perl -p0e 's/> *</></g' | grep -E '<logger name="changeRequest" level="[^"]+" additivity="false">' >/dev/null 2>&1 | ||
| then | ||
| sed -i 's%^ *</configuration>% <logger name="changeRequest" level="info" additivity="false">\n <appender-ref ref="OPSLOG" />\n <appender-ref ref="STDOUT" />\n </logger>\n</configuration>%' /opt/rudder/etc/logback.xml | ||
| fi | ||
| } |
There was a problem hiding this comment.
This would create an empty function which is not good. Either use ':' in place of empty content or remove the function completly
There was a problem hiding this comment.
I prefer keeping the function so we remember there can me some steps of migrating logback.xml
|
PR updated |
VinceMacBuche
force-pushed
the
ust_6911/remove_migration_process_from_old_version_to_3_1
branch
from
6b6df68
to
be8bb2f
Compare
|
PR updated |
VinceMacBuche
force-pushed
the
ust_6911/remove_migration_process_from_old_version_to_3_1
branch
from
be8bb2f
to
9c48249
Compare
|
OK ! |
Kegeruneku
pushed a commit
that referenced
this pull request
Jul 1, 2015
…process_from_old_version_to_3_1 Fixes #6911: Remove migration process from old version to 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/6911