Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #7026: The package doesn't build 3.2 on solaris #715

Merged
merged 1 commit into from
Jul 23, 2015
Merged

Fixes #7026: The package doesn't build 3.2 on solaris #715

merged 1 commit into from
Jul 23, 2015

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck force-pushed the bug_7026/the_package_doesn_t_build_3_2_on_solaris branch from 9efa97d to dea7372 Compare July 23, 2015 07:13
@peckpeck
Copy link
Member Author

PR updated

VinceMacBuche
VinceMacBuche reviewed Jul 23, 2015
View reviewed changes
rudder-agent/SOURCES/Makefile
@@ -442,6 +442,10 @@ ifeq ($(INSTALL),ginstall)
endif
cd fusioninventory-agent && PERL_MM_USE_DEFAULT=1 $(INSTALL_DIR)/bin/perl Makefile.PL --default PREFIX=$(RUDDER_DIR)
cd fusioninventory-agent && $(MAKE_COMMAND) install DESTDIR=$(DESTDIR)
# bug in fusion installer that doesn't set the right owner to some files
chown root $(DESTDIR) opt/rudder/share/fusioninventory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you change owner of $DESTDIR three times ? or have you missed a slash between DESTDIR and the path ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point :)

@peckpeck
Copy link
Member Author

PR updated

@peckpeck peckpeck force-pushed the bug_7026/the_package_doesn_t_build_3_2_on_solaris branch from dea7372 to 53fbd6c Compare July 23, 2015 08:23
@VinceMacBuche
Copy link
Member

Seems good ! merging!

VinceMacBuche added a commit that referenced this pull request Jul 23, 2015
@VinceMacBuche
Merge pull request #715 from peckpeck/bug_7026/the_package_doesn_t_bu…
a89fcf1 
…ild_3_2_on_solaris

Fixes #7026: The package doesn't build 3.2 on solaris
@VinceMacBuche VinceMacBuche merged commit a89fcf1 into Normation:master Jul 23, 2015
peckpeck added a commit that referenced this pull request Nov 2, 2015
@peckpeck
Revert "Merge pull request #715 from peckpeck/bug_7026/the_package_do…
1739938 
…esn_t_build_3_2_on_solaris"

This reverts commit a89fcf1, reversing
changes made to 7756682.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@peckpeck @VinceMacBuche