Fixes #7189: issues with process management on physical hosting LXC containers #747
Conversation
| PS="${RUDDERPS} -E 0" | ||
| ns=$(ps -h -o utsns --pid $$ 2>/dev/null) | ||
| if [ $? -eq 0 ]; then # we have namespaces | ||
| PS_COMMAND="ps -h -e -O utsns | grep -E '^[[:space:]]*[[:digit:]]*[[:space:]]+${ns}'" |
There was a problem hiding this comment.
Can we consider a namespace-enabled ps binary compatible with OpenVZ ?
There was a problem hiding this comment.
I don't know, the openvz version I tried didn't have namespaces
There was a problem hiding this comment.
I'm asking because this command works on my Debian jessie (without any container management system installed, just because systemd is here seems to be enough) and in the case you have a ns enabled ps and OpenVZ installed, this modification would basically break OpenVZ support I guess (the vzps cases wouldn't even be evaluated)
Maybe we should make two separate if's to separate Docker/LXC support (namespaces) and OpenVZ one (/proc/bs/0 presence)
There was a problem hiding this comment.
We can revers the test logic and first detect openvz, if it is present, user will probably use openvz and not namespace based containers
peckpeck
force-pushed
the
bug_7189/issues_with_process_management_on_physical_hosting_lxc_containers
branch
from
8ca35f3
to
1b122bf
Compare
|
PR updated |
peckpeck
force-pushed
the
bug_7189/issues_with_process_management_on_physical_hosting_lxc_containers
branch
from
1b122bf
to
2f667ce
Compare
|
PR updated |
|
Looks good ! |
…nagement_on_physical_hosting_lxc_containers Fixes #7189: issues with process management on physical hosting LXC containers
https://www.rudder-project.org/redmine/issues/7189