Fixes #7222: Allow technique auto-commit disable #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, I hadn't seen the previous PR |
| # Schedule a Technique library reload because of the update | ||
| trigger_technique_library_reload | ||
| if [ x"$RUDDER_NO_TECHNIQUE_AUTOCOMMIT" != x"1" ]; then | ||
| cd ${CONFIGURATION_REPOSITORY}/ && git add -A ${2} && git commit -m "Upgrade system Techniques from ${SRCTECHDIR} - automatically done by rudder-upgrade script" >/dev/null 2>&1 |
There was a problem hiding this comment.
I know it's not some code you wrote, but can you always use the "${VAR}" form ?
When an update is done, and one has customized some system techniques, the automatic git commit and technique library reload may not be wanted. This commit allows to specify an environment variable during an update to disable this automated commit and warns the user to do that manually.
matya
force-pushed
the
patch-7222-disable-autocommit-of-system-policy
branch
from
7278092
to
9d179fb
Compare
|
@peckpeck a few more, and I get used to your coding style... :) |
| cd ${CONFIGURATION_REPOSITORY}/ && git add -A ${2} && git commit -m "Upgrade system Techniques from ${SRCTECHDIR} - automatically done by rudder-upgrade script" >/dev/null 2>&1 | ||
| # Schedule a Technique library reload because of the update | ||
| trigger_technique_library_reload | ||
| if [ x"${RUDDER_NO_TECHNIQUE_AUTOCOMMIT}" != x"1" ]; then |
|
Good, merging |
peckpeck
added a commit
that referenced
this pull request
Feb 19, 2016
…ystem-policy Fixes #7222: Allow technique auto-commit disable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an update is done, and one has customized some system techniques,
the automatic git commit and technique library reload may not be wanted.
This commit allows to specify an environment variable during an update
to disable this automated commit and warns the user to do that manually.