Fixes #7358: Preliminary support for freebsd #778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, as changes. However 1) it needs rebasing :), 2) I think the dependency updates should be in a separate ticket to make sure they show up in the changelog. |
|
PR updated |
peckpeck
force-pushed
the
ust_7358/preliminary_support_for_freebsd
branch
from
d7c9f19
to
0ff6ee8
Compare
|
PR updated |
peckpeck
force-pushed
the
ust_7358/preliminary_support_for_freebsd
branch
from
0ff6ee8
to
0503a00
Compare
peckpeck
force-pushed
the
ust_7358/preliminary_support_for_freebsd
branch
from
0503a00
to
b6f1f82
Compare
|
PR updated |
|
Looks good ! |
Kegeruneku
pushed a commit
that referenced
this pull request
Nov 10, 2015
…r_freebsd Fixes #7358: Preliminary support for freebsd
| $(GET) $(TMP_DIR)/lmdb.tgz http://www.normation.com/tarball/lmdb-$(LMDB_RELEASE).tar.gz | ||
| gunzip < $(TMP_DIR)/lmdb.tgz | $(TAR) xf - | ||
| mv ./lmdb-$(LMDB_RELEASE) ./lmdb-source | ||
| ======= | ||
| $(WGET) -O $(TMP_DIR)/lmdb.tgz http://www.normation.com/tarball/lmdb/lmdb-$(LMDB_RELEASE).tar.gz |
There was a problem hiding this comment.
Pretty sure this should be $(GET) not $(WGET)...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7358