Fixes #3762 - Prevent global parameters script to fail installation of rudder-webapp #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Approved. |
| # - 2.7.0 : Migration LDAP to add the global parameter ou | ||
| LDAP_TEST_GLOBAL_PARAMETER=$(/opt/rudder/sbin/slapcat 2>/dev/null | grep "dn: ou=Parameters,ou=Rudder,cn=rudder-configuration" | wc -l) | ||
| if [ ${LDAP_TEST_GLOBAL_PARAMETER} -eq 0 ]; then | ||
| echo "INFO: The Rudder OpenLDAP schema is not up to date, adding Global Parameter ou." |
There was a problem hiding this comment.
This should be "echo -n", and finish with "...".
You made the new conventions just earlier this week, please respect your own creation!!!
|
Pull Request Updated |
|
PR reupdated |
nperron
pushed a commit
that referenced
this pull request
Jul 18, 2013
…_parameters_scripts_to_fail_installation_of_rudder_webapp Fixes #3762 - Prevent global parameters script to fail installation of rudder-webapp
nperron
deleted the
ust_33749/int/3762_prevent_global_parameters_scripts_to_fail_installation_of_rudder_webapp
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3762 - Prevent global parameters script to fail installation of rudder-webapp