Fixes #7992: Openssl build breaks debian packaging #890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -45,14 +45,12 @@ FETCH = fetch -q -o | |||
| ifneq (,$(wildcard /usr/bin/curl)) | |||
| GET = $(PROXY_ENV) $(CURL) | |||
| GET_OPT = --curl | |||
| else | |||
| ifneq (,$(wildcard /usr/bin/fetch)) | |||
| else ifneq (,$(wildcard /usr/bin/fetch)) | |||
There was a problem hiding this comment.
This is just the correct way to write elsif in makefiles
|
PR updated |
peckpeck
force-pushed
the
bug_7992/openssl_build_breaks_debian_packaging
branch
from
9ba1039
to
6e31f34
Compare
| @@ -90,6 +88,9 @@ endif | |||
| # Hack needed because openssl is not guessing correctly the architecture on solaris 32bits | |||
| ifeq (i386-pc-solaris2.10,$(shell ./config.guess)) | |||
| SSL_CONFIGURE:=./Configure solaris-x86-gcc | |||
| # Hack needed because openssl is not guessing correctly the architecture on debian 32 bits chroot | |||
| else ifeq (i386,$(shell [ -x /usr/bin/dpkg ] && dpkg --print-architecture)) | |||
There was a problem hiding this comment.
If /usr/bin/dpkg does not exist, this will return 1. Will make complain?
There was a problem hiding this comment.
No, it will just ignore it
jooooooon
added a commit
that referenced
this pull request
Mar 1, 2016
…ebian_packaging Fixes #7992: Openssl build breaks debian packaging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7992