Fixes #8232: Apache config does not get cleaned up after removal of rudder-webapp #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| %if 0%{?sles_version} | ||
| # Remove required includes in the SLES apache2 configuration | ||
| if grep -qE "^. /etc/sysconfig/rudder-apache$" /etc/sysconfig/apache2; then |
There was a problem hiding this comment.
The grep is already done by the sed line since sed won't do anything if there is no change.
Shouldn't we check the existence of the file instead ? (in case the user remove apache at the same time)
There was a problem hiding this comment.
Yes, good point and good idea!
jooooooon
force-pushed
the
bug_8232/apache_config_does_not_get_cleaned_up_after_removal_of_rudder_webapp
branch
from
e0c4bfd
to
4742586
Compare
|
Commit modified |
|
Good, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/8232