-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7833: Upgrade to CFEngine 3.7.3 #940
Fixes #7833: Upgrade to CFEngine 3.7.3 #940
Conversation
Commit modified |
df431a9
to
7c91201
Compare
We are almost even with upstream! We still have to keep the patch for the runlog file (it has only been integrated upsteam in 3.8). Added the patches for:
I also integrated the tests for these patches, which was not always for previous Rudder releases. We should be able to run as many CFEngine tests as possible against our agent. |
This is awesome ! |
7c91201
to
7d9686e
Compare
PR rebased |
7d9686e
to
693275e
Compare
Commit modified |
The callstack triggers a significant amount of code in ncf 1.0, I don't think we should enable it in a minor release |
peckpeck wrote:
This is targeted to master, so that won't happen. |
@jooooooon yes, I was just replying to @ncharles who wanted to target it to 3.2 |
Oh yes, sorry @peckpeck, somehow I missed the entire conversation. That's ok then. |
https://www.rudder-project.org/redmine/issues/7833