This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Fixes #11063: Updating properties does not propagate on nodes #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // look for the property value in the node to know if an update is needed. | ||
| // we only care about value here (not provider or other meta-info) | ||
| nodeInfo.properties.find(_.name == property.name).map(_.value) match { | ||
| case Some(property.value) => Full(NodeUpdateResult.Unchanged(nodeInfo.id)) |
There was a problem hiding this comment.
Hard to find that the value of the Node property is equal to value of the datasource property (property.value), maybe easier with changing name of property ('datasourceProperty'?)
fanf
force-pushed
the
bug_11063/updating_properties_does_not_propagate_on_nodes
branch
from
3388ce3
to
c6beafa
Compare
|
PR rebased |
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11063