This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Fixes #11412: Can not delete a node property set by datasources #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| case Post( "reload" :: Nil, req) => { | ||
| implicit val prettify = extractor.extractPrettify(req.params) | ||
| implicit val action = "reloadAllDatasourcesAllNodes" | ||
| val actor = RestUtils.getActor(req) | ||
|
|
||
| apiService.reloadDataAllNodes(actor) |
There was a problem hiding this comment.
hum. No idea, it was not supposed to be done.
| @@ -9,5 +9,6 @@ target* | |||
| .externalToolBuilders | |||
| datasources/ | |||
| files.txz | |||
| scripts.txz | |||
There was a problem hiding this comment.
Why do you include scripts.txz ?
There was a problem hiding this comment.
because it was not included in the gitignore but is a side product of compilation. It must not be commited.
|
Two litle remarks that are not related with the fix Nice fix though, Nice it can clean 'deleted' datasource! |
ncharles
reviewed
Sep 22, 2017
|
|
||
| apiService.clearDataAllNodesFor(actor, DataSourceId(datasourceId)) match { | ||
| case Full(_) => toJsonResponse(None, JString(s"Data for all nodes, for data source '${datasourceId}', cleared")) | ||
| case eb:EmptyBox => toJsonError(None, JString((eb ?~! "Could not clear data source property").messageChain)) |
There was a problem hiding this comment.
Could you add the datasourceId in the message ?
| @@ -130,7 +152,7 @@ class DataSourceApi9 ( | |||
| } | |||
|
|
|||
| case Delete(sourceId :: Nil, req) => { | |||
| response(apiService.deleteSource(DataSourceId(sourceId)), req, "Could not delete data sources", None)("getDataSource") | |||
| response(apiService.deleteSource(DataSourceId(sourceId)), req, "Could not delete data sources", None)("deteteDataSource") | |||
There was a problem hiding this comment.
Could you add also here the data source id ?
|
PR rebased |
fanf
force-pushed
the
bug_11412/can_not_delete_a_node_property_set_by_datasources
branch
from
5721872
to
bbf3034
Compare
|
OK, merging this PR |
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11412