This repository has been archived by the owner on Feb 8, 2019. It is now read-only.
Fixes #11429: Update datasource to Rudder 4.2 license framework #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val isEnabled = true | ||
| val enabledStatus = DatasourcesStatus.Enabled | ||
| val licenseInformation = None | ||
| final class CheckRudderPluginDatasourcesEnableImpl() extends PluginStatus { |
There was a problem hiding this comment.
Why not using: AlwaysEnabledPluginStatus instead ?
There was a problem hiding this comment.
and removing this file (and removing lines from pom.xml if default is now useless
There was a problem hiding this comment.
because we need the correct name to be able to instanciate that service in the plugin module. I don't have any simple way to make that work without a full-blown IoC or Java Service arch. I don't want to use them.
|
|
||
| maybeInfo.fold( error => DataSourceLogger.error(error) , ok => DataSourceLogger.warn("License signature is valid.") ) | ||
| //log at that point is we read the license information for the plugin | ||
| maybeInfo.fold( error => DataSourceLogger.error(error) , ok => DataSourceLogger.info("Plugin datasource has a license and the license signature is valid.") ) |
There was a problem hiding this comment.
I wanted to write "Plugin '${plugin name}' actually :)
fanf
force-pushed
the
ust_11429/update_datasource_to_rudder_4_2_license_framework
branch
from
06fbc07
to
d09c18c
Compare
|
PR rebased |
|
OK, merging this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/11429