Fixes #23830: Migrate users and supervised target APIs in change-validation to zio-json #614
Conversation
|
Commit modified |
clarktsiory
force-pushed
the
arch_23830/migrate_users_and_supervised_target_apis_in_change_validation_to_zio_json
branch
from
84730d8
to
df34155
Compare
|
PR updated with a new commit |
|
|
||
| @RunWith(classOf[JUnitRunner]) | ||
| class MigrateSupervisedGroupsTests extends Specification with JsonSpecMatcher with AfterAll { | ||
| isolated |
There was a problem hiding this comment.
it needs to be just sequential, not isolated, else the whole set up is done again, which is costly and can lead to error depending of the millesecond of directory creation, for ex:
There was a problem hiding this comment.
(previously I got a "directory already exist", which was more explicit)
|
|
||
| "do nothing if the directory is not writable" in { | ||
| val unsupervisedRepo = new UnsupervisedTargetsRepository(tmpDirPath, "unsupervised-targets.json") | ||
| tmpDir.setPermissions(PosixFilePermissions.fromString("r--r--r--").asScala.toSet) |
There was a problem hiding this comment.
this need to be at least rw-r--r-- else the test modifying it fails. (SupervisedTargetsApiTest, the POST)
There was a problem hiding this comment.
That's right the tests were not passing ! The change was there :
rw 😄)
clarktsiory
force-pushed
the
arch_23830/migrate_users_and_supervised_target_apis_in_change_validation_to_zio_json
branch
from
50c26a1
to
31df6b8
Compare
|
This PR is not mergeable to upper versions. |
|
OK, squash merging this PR |
fanf
force-pushed
the
arch_23830/migrate_users_and_supervised_target_apis_in_change_validation_to_zio_json
branch
from
31df6b8
to
eb13a14
Compare
https://issues.rudder.io/issues/23830
This is the migration of 2 APIs in the change-validation plugin to use zio-json to replace lift-json (there is one bigger REST API to migrate still, and in consequence lots of refactoring from the lift
Boxtype to the zioIOResulttype in the interfaces, but this will be made in another PR).I kept the same behavior everywhere as I could, so there may be 'weird' (rather uncommon) things such as logging a decoding error...
I also added tests to the APIs using the yaml format, and to the repositories, which had some saving 'workflow' to test...