Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #24298: Display current session permission and split appart form to update user details #676

Merged
merged 1 commit into from Mar 4, 2024
Merged

Fixes #24298: Display current session permission and split appart form to update user details #676

merged 1 commit into from Mar 4, 2024

Conversation

clarktsiory
Copy link
Contributor

@clarktsiory clarktsiory commented Mar 1, 2024 •
edited

https://issues.rudder.io/issues/24298

  • Splitting the endpoints in 2 : the existing one should only be used for the "roles" and "password" update, the new one to update user info : "name", "email" and "otherInfo"
  • Updating the display to keep consistency and have clearer messages when roles are defined both in the users.xml file and from the provider. For that we have migrated the "role extension" ADT from the plugin to Rudder in this PR, and pattern matching on it now makes the logic of handling both file and external provider more fluent.

@clarktsiory clarktsiory requested a review from fanf March 1, 2024 17:19
@clarktsiory clarktsiory changed the base branch from branches/rudder/7.3 to backports/7.3.12/24146 March 1, 2024 17:19
@clarktsiory clarktsiory marked this pull request as draft March 1, 2024 17:20
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

4 similar comments
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory clarktsiory marked this pull request as ready for review March 4, 2024 12:52
@clarktsiory
Copy link
Contributor Author

PR updated with a new commit

@clarktsiory clarktsiory force-pushed the bug_24298/display_current_session_permission_and_split_appart_form_to_update_user_details branch from a769ac6 to 062b142 Compare March 4, 2024 14:05
@clarktsiory clarktsiory force-pushed the bug_24298/display_current_session_permission_and_split_appart_form_to_update_user_details branch from 062b142 to 73340f8 Compare March 4, 2024 14:07
@clarktsiory
Copy link
Contributor Author

PR rebased and squashed

fanf
fanf approved these changes Mar 4, 2024
View reviewed changes
Copy link
Member

@fanf fanf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fanf fanf merged commit 27fd474 into Normation:backports/7.3.12/24146 Mar 4, 2024
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fanf fanf fanf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@clarktsiory @fanf