Fixes #24304: Deleted users should change status on file reload #5428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clarktsiory
changed the base branch from
branches/rudder/7.3
to
backports/7.3.12/24146
|
PR updated with a new commit |
1 similar comment
|
PR updated with a new commit |
|
PR updated with a new commit |
clarktsiory
force-pushed
the
bug_24304/deleted_users_should_change_status_on_file_reload
branch
from
bbe7eec
to
c7c09e0
Compare
|
PR rebased and squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.rudder.io/issues/24304
The change of not updating user origin should not have been made in this previous PR : it breaks tests and users can no longer be set as managed by OIDC when logging-in the first time and already being a file user.
Users that are from the same origin should not be taken into account when changing user status (
setExistingUsers)