Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #7927: Remove .cf files from initial promises #1003

Conversation

peckpeck
Copy link
Member

@peckpeck peckpeck commented Aug 3, 2016

@peckpeck
Copy link
Member Author

peckpeck commented Aug 3, 2016

Merge #1002 first

@peckpeck
Copy link
Member Author

peckpeck commented Aug 3, 2016

Big cleanup!

@peckpeck
Copy link
Member Author

peckpeck commented Aug 4, 2016

Commit modified

@peckpeck peckpeck force-pushed the arch_7927/remove_cf_files_from_initial_promises branch from 62e47b7 to f84662a Compare August 4, 2016 08:45
@peckpeck
Copy link
Member Author

peckpeck commented Aug 4, 2016

PR rebased

@peckpeck peckpeck force-pushed the arch_7927/remove_cf_files_from_initial_promises branch from f84662a to a6e534a Compare August 4, 2016 15:03
@peckpeck
Copy link
Member Author

peckpeck commented Aug 4, 2016

PR rebased

@peckpeck peckpeck force-pushed the arch_7927/remove_cf_files_from_initial_promises branch from a6e534a to bdfd275 Compare August 4, 2016 15:07
"rudder_promises_timestamp" string => "rudder_promises_generated";
"rudder_promises_timestamp_tmp" string => "rudder_promises_generated.tmp";
"rudder_promises_timestamp" string => "rudder_promises-generated";
"rudder_promises_timestamp_tmp" string => "rudder_promises-generated.tmp";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines have a mix of _ and -

@peckpeck
Copy link
Member Author

peckpeck commented Aug 4, 2016

Commit modified

@peckpeck peckpeck force-pushed the arch_7927/remove_cf_files_from_initial_promises branch from bdfd275 to fc256f7 Compare August 4, 2016 15:17
@Normation-Quality-Assistant
Copy link
Contributor

OK, merging this PR

@Normation-Quality-Assistant Normation-Quality-Assistant merged commit fc256f7 into Normation:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants