New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #7927: Remove .cf files from initial promises #1003
Merged
Normation-Quality-Assistant
merged 1 commit into
Normation:master
from
peckpeck:arch_7927/remove_cf_files_from_initial_promises
Aug 4, 2016
Merged
Fixes #7927: Remove .cf files from initial promises #1003
Normation-Quality-Assistant
merged 1 commit into
Normation:master
from
peckpeck:arch_7927/remove_cf_files_from_initial_promises
Aug 4, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge #1002 first |
Big cleanup! |
Commit modified |
peckpeck
force-pushed
the
arch_7927/remove_cf_files_from_initial_promises
branch
from
August 4, 2016 08:45
62e47b7
to
f84662a
Compare
PR rebased |
peckpeck
force-pushed
the
arch_7927/remove_cf_files_from_initial_promises
branch
from
August 4, 2016 15:03
f84662a
to
a6e534a
Compare
PR rebased |
peckpeck
force-pushed
the
arch_7927/remove_cf_files_from_initial_promises
branch
from
August 4, 2016 15:07
a6e534a
to
bdfd275
Compare
"rudder_promises_timestamp" string => "rudder_promises_generated"; | ||
"rudder_promises_timestamp_tmp" string => "rudder_promises_generated.tmp"; | ||
"rudder_promises_timestamp" string => "rudder_promises-generated"; | ||
"rudder_promises_timestamp_tmp" string => "rudder_promises-generated.tmp"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines have a mix of _ and -
Commit modified |
peckpeck
force-pushed
the
arch_7927/remove_cf_files_from_initial_promises
branch
from
August 4, 2016 15:17
bdfd275
to
fc256f7
Compare
OK, merging this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/7927