Fixes #9041: Change system promises to call list-compatible-inputs with Rudder version #1039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit modified |
amousset
force-pushed
the
ust_9041/change_system_promises_to_call_list_compatible_inputs_with_rudder_version
branch
from
74524bc
to
2b5bd76
Compare
…th Rudder version
|
Commit modified |
amousset
force-pushed
the
ust_9041/change_system_promises_to_call_list_compatible_inputs_with_rudder_version
branch
from
2b5bd76
to
fc5f4fa
Compare
jooooooon
reviewed
Sep 21, 2016
| "path_ncf_local_inputs_40" slist => splitstring(execresult("${list_compatible_inputs} ${sys.cf_version} '${ncf_path}' local/40_it_ops_knowledge", "${shell_type}"), "\n", 10000); | ||
| "path_ncf_local_inputs_50" slist => splitstring(execresult("${list_compatible_inputs} ${sys.cf_version} '${ncf_path}' local/50_techniques", "${shell_type}"), "\n", 10000); | ||
| "path_ncf_local_inputs_60" slist => splitstring(execresult("${list_compatible_inputs} ${sys.cf_version} '${ncf_path}' local/60_services", "${shell_type}"), "\n", 10000); | ||
| "version_data" data => readjson("${rudder_version_file}", 4000); |
There was a problem hiding this comment.
I think this will fail on a node that has not got a recent rudder-agent (so no rudder_version_file on the filesystem). This can happen if ncf is upgraded on the rudder server, without an agent upgrade - a common scenario.
I think we should protect against this file not existing. (check it exists before trying to read it)
|
We will use a capability based filter instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.rudder-project.org/redmine/issues/9041